Add Superforms, update RenameAssetModal #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
reviewed
Jun 14, 2024
Comment on lines
+33
to
+37
| const validationSchema = object({ | ||
| newName: string() | ||
| .required("Enter a name!") | ||
| .matches(VALID_NAME_PATTERN, INVALID_NAME_MESSAGE), | ||
| }); |
There was a problem hiding this comment.
I can't seem to trigger this validation message. When I leave the form empty, then try to submit it, I don't see the message "Enter a name!" pop up anywhere.
There was a problem hiding this comment.
Unifying the Input components meant bringing over the conditionally shown error behavior from InputV2. One of the conditionals is that there exists a value in the input. Obviously that's in conflict with an error for a missing value... Turned on the alwaysShowError prop for now, though I may consider removing this conditional behavior as I convert more forms.
ericpgreen2
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the process of replacing svelte-forms-lib, which is no longer supported, with Superforms.
It reworks the
RenameAssetModalto use the new API. Follow up PRs will replace other uses of the old form library.