Cloud UI: Fix 401 error on the Project page due to stale JWT #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
approved these changes
Jun 15, 2024
ericpgreen2
added a commit
that referenced
this pull request
Jun 17, 2024
* Make sure to refetch stale JWTs * Make sure we don't keep a stale JWT in the cache * Don't show a full-screen error page for runtime 401s on the project page * Destructure store to avoid remounting Query Observer on navigation * Use correct query key for runtime information * Fix breadcrumb flicker * Only increment `receivedAt` if the JWT has actually changed * Backwards-compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, re-visiting a Project page can trigger a 401 error. In the error case, a stale JWT sits in the
GetProjectQuery Cache and is used in a runtime request. The 401 triggers a full-screen error page.This PR does a few things to mitigate this, notably:
refetchOnMount,refetchOnWindowFocus, andrefetchOnReconnectto refetch the JWT when the user re-visits the pagecacheTimeto garbage-collect old JWTsBug report in Slack