feat: Adding tanstack query wrapper around LocalService #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think it only works for React out of the box, but did you look into whether there's anything useful in https://github.com/connectrpc/connect-query-es?
Comment on lines
16
to
17
| import type { RpcStatus } from "@rilldata/web-common/runtime-client/gen/index.schemas"; | ||
| import type { ErrorType } from "@rilldata/web-common/runtime-client/http-client"; |
There was a problem hiding this comment.
Shouldn't it use the Connect error types instead of the ones from Orval? See https://connectrpc.com/docs/web/errors
Comment on lines
4
to
7
| import type { | ||
| CreateMutationOptions, | ||
| CreateQueryOptions, | ||
| } from "@rilldata/svelte-query"; |
There was a problem hiding this comment.
Shouldn't it use @tanstack/svelte-query? That is used below for import { createMutation, createQuery }
begelundmuller
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out tanstack wrapper around LocalService from #5106