Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Refactor the "Add data" forms #5162

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Fix/Refactor the "Add data" forms #5162

merged 14 commits into from
Jul 24, 2024

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Jun 28, 2024 •
edited
Loading

This PR cleans-up the various "Add Data" forms. Closes #5140.

  • Fixes form validation. Input elements were missing an alwaysShowError prop (added in this PR).
  • Moves DuckDB from the OLAP Connector section to the Sources section.
  • Moves the Source forms' source name property declaration from the frontend to the backend, where the rest of the properties are declared.
  • Uses ConfigProperties not SourceProperties for OLAP connector forms.
  • Incorporates the noPrompt attribute of the OLAP connector specs (discussed in CLI: Don't prompt for both DSN and parts in rill env configure #5200, implemented in CLI : Add a no prompt for cases when dsn can be configured individually #5298) to hide the DSN field from the UI.
  • Adds validation for the host fields to prevent duplicative https:// prefixes
  • Improves the spacing of the Request-a-Connector form.

@ericpgreen2 ericpgreen2 self-assigned this Jun 28, 2024
@ericpgreen2 ericpgreen2 changed the title Fix validation of DuckDB connector form Fix DuckDB connector form Jun 28, 2024
@ericpgreen2 ericpgreen2 marked this pull request as draft July 10, 2024 15:07
@ericpgreen2 ericpgreen2 changed the title Fix DuckDB connector form Refactor OLAP connector forms Jul 15, 2024
@ericpgreen2 ericpgreen2 changed the title Refactor OLAP connector forms Fix/Refactor the "Add data" forms Jul 15, 2024
@ericpgreen2 ericpgreen2 marked this pull request as ready for review July 15, 2024 19:02
@ericpgreen2 ericpgreen2 mentioned this pull request Jul 23, 2024
Merged
@ericpgreen2 ericpgreen2 merged commit 09ed457 into main Jul 24, 2024
6 checks passed
@ericpgreen2 ericpgreen2 deleted the fix-duckdb-form-validation branch July 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-anshul k-anshul k-anshul approved these changes

Assignees

@ericpgreen2 ericpgreen2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot add a DuckDB source (Source Name is Required)
2 participants
@ericpgreen2 @k-anshul