Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public URL follow-ups #5208

Merged
merged 8 commits into from
Jul 29, 2024
Merged

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Jul 8, 2024

This PR:

  • Automatically hides any filtered dimensions
  • Only specifies metricsViewFields if a subset of fields is selected
  • Shows the actual API error message (e.g. "metrics view filter size exceeds limit (got 13108 bytes, but the limit is 1024 bytes)")
  • Upon successfully creating a Public URL, automatically copies the URL to clipboard
  • Switches terminology from "Public Link" to "Public URL" for copy consistency
  • Uses semibold not bold for the header text

Addresses:

@ericpgreen2 ericpgreen2 self-assigned this Jul 8, 2024
@ericpgreen2 ericpgreen2 changed the title Cleanup the Shareable URL form submission Public Link follow-ups Jul 25, 2024
@ericpgreen2 ericpgreen2 changed the title Public Link follow-ups Public URL follow-ups Jul 25, 2024
@ericpgreen2 ericpgreen2 marked this pull request as ready for review July 26, 2024 21:53
@ericpgreen2 ericpgreen2 merged commit c895e3c into main Jul 29, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the shareable-url-form-submission-cleanups branch July 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants