Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groups checks for mock users #5209

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Fix groups checks for mock users #5209

merged 5 commits into from
Jul 8, 2024

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Jul 8, 2024 •
edited
Loading

Changes IssueDevJWT to POST so it can use JSON to correctly pass a list of groups (with GET, Orval serializes them as a comma-separated list)

@begelundmuller begelundmuller added the blocker A release blocker issue that should be resolved before a new release label Jul 8, 2024
@begelundmuller begelundmuller self-assigned this Jul 8, 2024
@begelundmuller begelundmuller requested review from ericpgreen2 and removed request for pjain1 July 8, 2024 17:03
pjain1
pjain1 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@pjain1 pjain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto changes look good, not sure if any more web change is needed as CI is failing

@ericpgreen2 ericpgreen2 merged commit 9cf8794 into main Jul 8, 2024
7 checks passed
@ericpgreen2 ericpgreen2 deleted the begelundmuller/fix-groups-mock-users branch July 8, 2024 20:53
ericpgreen2 added a commit that referenced this pull request Jul 8, 2024
@begelundmuller @ericpgreen2
Fix groups checks for mock users (#5209)
7b0b3ee 
* Fix groups checks for mock users

* Fix TS error

* Patch `add-signal-argument` script to be flexbile for any service

* Add `signal` argument to Orval-generated POST functions

* Remove comment

---------

Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

@pjain1 pjain1 pjain1 approved these changes

Assignees

@begelundmuller begelundmuller

Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@begelundmuller @pjain1 @ericpgreen2