-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a glob
resolver for listing and partitioning files in an object store
#5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
changed the title
Runtime: Support listing files in an ObjectStore
Support a Jul 18, 2024
glob
resolver for listing and partitioning files in an object store
k-anshul
approved these changes
Jul 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes introduces a
glob
resolver that lists and optionally partitions files in an object store connector. In connection with that, it also:ListObjects
function ondrivers.ObjectStore
mock_object_store
driver for writing tests against object store driversruntime.Resolve
to support efficient iteration over aResolverResult
This resolver will be used in a follow-up PR to introduce support for incremental ingestion from object stores by calling the
glob
resolver to obtain values to split ingestion by.Example usage for listing out individual files:
Example usage for listing out files partitioned by directory:
Example usage for listing out files partitioned using Hive partitioning:
Example usage for doing post-processing with DuckDB (note this is an advanced feature needed to address some complex partition processing use cases):