Fix: Protect against table names with spaces in generated models #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
changed the title
nishantmonu51
added
the
blocker
AdityaHegde
approved these changes
Jul 31, 2024
| @@ -75,16 +77,22 @@ export async function createModelFromTable( | |||
| const topComments = | |||
| "-- Model SQL\n-- Reference documentation: https://docs.rilldata.com/reference/project-files/models"; | |||
| const connectorLine = `-- @connector: ${connector}`; | |||
| const selectStatement = `select * from ${sufficientlyQualifiedTableName}`; | |||
| const selectStatement = hasSpaces(sufficientlyQualifiedTableName) | |||
There was a problem hiding this comment.
Why not always surround with quotes? Would be convenient when the name is changed later to include spaces.
There was a problem hiding this comment.
Fair, it's subjective but I think it's a little cleaner to omit the quotes if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rilldata/rill-private-issues/issues/404
Additionally, this PR removes the
createModelFromSourcefunction in favor ofcreateModelFromTable.