Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel drag events of directory/file when the native context menu is opened #5344

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Cancel drag events of directory/file when the native context menu is opened #5344

merged 3 commits into from
Jul 29, 2024

Conversation

lovincyrus
Copy link
Contributor

This PR removes the dangling directory/file when the native context menu is opened.

5337.mov

closes #5337

ericpgreen2
ericpgreen2 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the board! 🙌 There's just a prettier issue (missing semicolon) to resolve before merging. Personally, I have "format on save" turned on in my editor. In theory, we could use Husky pre-commit hooks for linting, but it hasn't really been pressing.

@lovincyrus lovincyrus merged commit 7efa791 into rilldata:main Jul 29, 2024
4 checks passed
@lovincyrus lovincyrus deleted the cyrus/cancel-dnd-in-navs-bug branch July 29, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

@AdityaHegde AdityaHegde Awaiting requested review from AdityaHegde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Explorer: Cancel drag events of directory/file when the native context menu is opened
2 participants
@lovincyrus @ericpgreen2