ClickHouse as a subprocess #5347
Conversation
cli/cmd/start/clickhouse.go
Outdated
| if _, err := os.Stat(destPath); err == nil { | ||
| // ClickHouse binary already exists | ||
| // TODO: Check compatibility in case the binary is outdated. | ||
| return destPath, nil | ||
| } |
There was a problem hiding this comment.
Can we just incorporate the version number in the path, i.e. ~/.rill/clickhouse/vXX/?
There was a problem hiding this comment.
I haven't found a way to determine the version of the Clickhouse binary without running and querying it.
There was a problem hiding this comment.
What if we pin to a specific version when downloading the binary? Like we pin to a specific DuckDB version. Then we would know it, right?
# Conflicts: # cli/cmd/start/start.go
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
…ckhouse-sub-process
| if err := e.cmd.Wait(); err != nil { | ||
| e.logger.Error("clickhouse server exited with an error", zap.Error(err)) | ||
| } |
There was a problem hiding this comment.
What about when there's a graceful shutdown (i.e. stop is called) – will ClickHouse shut down with status 0 or will there be some kind of error? If there's an error, we should probably skip it here.
There was a problem hiding this comment.
There is no error in case of a graceful shutdown
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Closes #5207