feat: Add dashboard state to error telemetry to better debug errors #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
reviewed
Jul 31, 2024
| ]); | ||
| } | ||
|
|
||
| private getDashboardState() { | ||
| // TODO: we need to also save other params that get added after |
There was a problem hiding this comment.
What about just storing the whole URL? The main goal is to make it easier to reproduce bugs, so it'd be great if we can just copy/paste the URL into our browser.
There was a problem hiding this comment.
Ya i thought we save org & project. I guess not, so it makes sense to do this
ericpgreen2
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Good from the frontend POV. @esevastyanov, can you please augment the data pipeline with this new pageURL field?
nishantmonu51
approved these changes
Jul 31, 2024
|
merging it, Lets create a separate ticket for the pipeline work. |
|
Created a ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/rilldata/rill-private-issues/issues/511