fix: Github connection follow ups

web-admin/src/features/projects/github/ConnectToGithubButton.svelte

@@ -10,6 +10,7 @@
   } from "@rilldata/web-common/components/alert-dialog";
   import { Button } from "@rilldata/web-common/components/button";
   import Github from "@rilldata/web-common/components/icons/Github.svelte";
+  import { openPopupWindow } from "@rilldata/web-common/lib/openPopupWindow";
   import { behaviourEvent } from "@rilldata/web-common/metrics/initMetrics";
   import { BehaviourEventAction } from "@rilldata/web-common/metrics/service/BehaviourEventTypes";
 
@@ -28,11 +29,7 @@
       },
     );
     // we need a popup window so we cannot use href
-    window.open(
-      "https://github.com/new",
-      "githubNewWindow",
-      "width=1024,height=600",
-    );
+    openPopupWindow("https://github.com/new", "githubNewWindow");
   }
 
   function handleContinue() {

web-admin/src/features/projects/github/GithubData.ts

@@ -6,6 +6,7 @@ import {
   getAdminServiceListGithubUserReposQueryKey,
   type RpcStatus,
 } from "@rilldata/web-admin/client";
+import { openPopupWindow } from "@rilldata/web-common/lib/openPopupWindow";
 import { queryClient } from "@rilldata/web-common/lib/svelte-query/globalQueryClient";
 import { waitUntil } from "@rilldata/web-common/lib/waitUtils";
 import { getContext, setContext } from "svelte";
@@ -98,11 +99,10 @@ export class GithubData {
       // no-op
     }
     if (this.windowCheckTimer) clearInterval(this.windowCheckTimer);
-    this.userPromptWindow = window.open(
+    this.userPromptWindow = openPopupWindow(
       // add `remote` to indicate the callback success dialog should auto close
       `${url}?remote=autoclose`,
       "githubWindow",
-      "width=1024,height=600",
     );
 
     // periodically check if the new window was closed

web-admin/src/features/projects/github/GithubRepoSelectionDialog.svelte

@@ -54,8 +54,8 @@
 
   // update data from project, this is needed if the user never leaves the status page and this component is not unmounted
   $: githubConnectionUpdater = new ProjectGithubConnectionUpdater(
-    project,
     organization,
+    project,
     currentUrl,
     currentSubpath,
     currentBranch,

web-common/src/features/dashboards/workspace/DeployDashboardCTA.svelte

@@ -71,7 +71,7 @@
       <DeployIcon size="150px" />
       <div class="flex flex-col">
         <AlertDialogHeader>
-          <AlertDialogTitle>Deploy this project for free</AlertDialogTitle>
+          <AlertDialogTitle>Deploy this project</AlertDialogTitle>
           <AlertDialogDescription>
             You’re about to deploy to Rill Cloud, where you can set alerts,
             share dashboards, and more. <a

web-common/src/lib/openPopupWindow.ts

@@ -0,0 +1,39 @@
+const WindowWidth = 1024;
+const WindowHeight = 600;
+
+/**
+ * Opens a popup window with {@link WindowWidth} and {@link WindowHeight}
+ */
+export function openPopupWindow(url: string, title: string) {
+  const dualScreenLeft =
+    window.screenLeft !== undefined ? window.screenLeft : window.screenX;
+  const dualScreenTop =
+    window.screenTop !== undefined ? window.screenTop : window.screenY;
+
+  const width = window.innerWidth
+    ? window.innerWidth
+    : document.documentElement.clientWidth
+      ? document.documentElement.clientWidth
+      : screen.width;
+  const height = window.innerHeight
+    ? window.innerHeight
+    : document.documentElement.clientHeight
+      ? document.documentElement.clientHeight
+      : screen.height;
+
+  const systemZoom = width / window.screen.availWidth;
+  const left = (width - WindowWidth) / 2 / systemZoom + dualScreenLeft;
+  const top = (height - WindowHeight) / 2 / systemZoom + dualScreenTop;
+
+  return window.open(
+    url,
+    title,
+    `
+      scrollbars=yes,
+      width=${WindowWidth / systemZoom}, 
+      height=${WindowHeight / systemZoom}, 
+      top=${top}, 
+      left=${left}
+      `,
+  );
+}