feat: Add orgnaization tabs and settings tab skeleton #5458
Conversation
AdityaHegde
commented
Aug 16, 2024
AdityaHegde
commented
- Adds tabs for organization that is hidden if the available tabs <= 1
- Adds skeleton for settings page that can be reused in project settings page.
There was a problem hiding this comment.
The project settings page looks great. I can definitely re-use it for the public URLs table.
Unsure about the addition of sub-navigation bar (1 in the screenshot). Ideally, we only have 1 nav bar to avoid confusion. Also asked for clarification on the design https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7?node-id=144-815#915050693
Should be Settings instead of Status
|
Yes @lovincyrus is correct, the intent was for only one tab bar to show at a time. The org tab bar when you're on an org page, the project tab bar when you're on a project page. |
AdityaHegde
force-pushed
the
adityahegde/org-settings-page
branch
from
cde4f74
to
fea0389
Compare
|
@lovincyrus The outline is not really visible to users. The start of rill logo aligns with the tab background when hovered. You can see that in the 1st image you posted. Side note the rill logo doesnt have a hover state in mocks but it does in UI. We should figure it out separately. |
| @@ -54,6 +55,7 @@ | |||
| $: onReportPage = !!report; | |||
| $: onMetricsExplorerPage = isMetricsExplorerPage($page); | |||
| $: onPublicURLPage = isPublicURLPage($page); | |||
| $: witinOrgPage = withinOrganization($page); | |||
| <LeftNav | ||
| title="Settings" | ||
| {basePage} | ||
| baseRoute="/[organization]/-/settings" | ||
| {navItems} | ||
| > | ||
| <slot /> | ||
| </LeftNav> |
There was a problem hiding this comment.
Rather than the main page content being a child of LeftNav, I think it'd be more conventional/semantic for the main page content and LeftNav component to be siblings, like:
<div class="layout-container">
<LeftNav {title} {basePage} {baseRoute} {navItems} />
<slot />
</div>
There was a problem hiding this comment.
With this approach, it'd also make sense to pull the "Settings" header out of the LeftNav component.
AdityaHegde
dismissed
lovincyrus’s stale review
Will be taking the comment in a future PR and fix for project tabs as well.
