Runtime: Cast Clickhouse DECIMALs to floats in metrics APIs #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
approved these changes
Aug 23, 2024
begelundmuller
deleted the
begelundmuller/cast-clickhouse-decimals-to-float
branch
begelundmuller
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go, ClickHouse returns
DECIMALtypes asstrings instead ofbigs when not explicitly scanned into a different data type. This PR casts those strings tofloat64s before returning them in the metrics APIs.Note that this is a bad practice, but something we have done historically for DuckDB numbers because the frontend can't yet handle non-float numbers.