convert select component, consolidate bookmark dialog

[briangregoryholmes]

No description provided.

[ericpgreen2]

@briangregoryholmes is this ready for review? Mind just fixing the code quality test?

[ericpgreen2]

Looks way better aesthetically.

UXQA – I tried the Create Bookmark form, and making a selection in the new Select component caused the dialog to close. See JAM.

Approving so you can merge after fixing.

[briangregoryholmes]

For the sake of practicality, I've solved this by consolidating the CreateBookmarkDialog and EditBookmarkDialog components into a single component that uses the ShadCN dialog. The previous component, from headless, was closing because it was naively detecting an outside click when selecting a menu item.

There is a lot that has to be done to make our dialog implementations more consistent throughout the application. The changes in this PR are small just to get it over the line.

I also changed the Bookmark input label from Name to Label because it seems like the 1Password plugin wants to autofill fields that are labeled Name.

[ericpgreen2]

I like the cleanup. Two UXQA findings:

1. The Bookmark dialog's absolute time range toggle doesn't seem to be respected. It always flips to "on". See Jam
2. The TimePicker component isn't seeming to create valid times. When I create a scheduled report, the chosen time isn't respected, and the "edit" form is not able to populate the time field correctly. See Jam.

[ericpgreen2]

It still seems like the Bookmark toggles aren't being respected. Toggling-on either "Save filters only" or "Absolute time range" is not retained. See Jam.

[briangregoryholmes]

Could not reproduce any issue with the filters only toggle, but the other one should be resolved.