Use validPercentOfTotal as source of truth
#5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Sep 10, 2024
| import { SortType } from "./proto-state/derived-types"; | ||
| import type { TimeControlState } from "./time-controls/time-control-store"; | ||
|
|
||
| const countRegex = /count(?=[^(]*\()/i; | ||
| const sumRegex = /sum(?=[^(]*\()/i; | ||
|
|
||
| export function isSummableMeasure(measure: MetricsViewSpecMeasureV2): boolean { |
There was a problem hiding this comment.
At some point, we should change this function name to isMeasureValidPercentOfTotal
|
Can you change the PR description & title to match the new code before merging? |
djbarnwal
changed the title
validPercentOfTotal as source of truth
ericpgreen2
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Add clickhouse functions which are summable * Rely on metrics spec for valid percent of total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rilldata/rill-private-issues/issues/608
Use
validPercentOfTotalas source of truth to validate if measure is summable. Also maintain support forsumandcountfor legacy dashboards not having the key in their spec.