Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canvas dashboards: set max width #5657

Merged
merged 4 commits into from
Sep 16, 2024
Merged

canvas dashboards: set max width #5657

merged 4 commits into from
Sep 16, 2024

Conversation

briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Sep 10, 2024

#5575

Open questions:

  • What should the max width be? This PR sets it to 1200px.
  • How should the dead space be presented? See below.
Screenshot 2024-09-10 at 9 57 00 AM

@briangregoryholmes briangregoryholmes self-assigned this Sep 10, 2024
@briangregoryholmes briangregoryholmes marked this pull request as ready for review September 10, 2024 17:13
@mindspank
Copy link
Contributor

Approved. 1200 looks fine as a width to me and easy to tweak if we'd want different widths.

@mindspank
Copy link
Contributor

@briangregoryholmes @ericpgreen2

Some notes, I don't consider them blockers and we can tweak now that we have the initial stub in place.

  • Should we go with 1440 instead?
  • Should we scroll the container or the page?
  • It looks a bit "dull" but at the same time it wont detract from the analysis. What do you think?

@briangregoryholmes
Copy link
Contributor Author

Bumped to 1440px and changed the scrolling element to the parent. Colors I'll leave for now, but I agree that it looks quite bland.

@briangregoryholmes briangregoryholmes merged commit 05a7d71 into main Sep 16, 2024
7 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/cd-max-width branch September 16, 2024 23:57
@briangregoryholmes briangregoryholmes linked an issue Sep 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Dashboard Width
2 participants