Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics view generation: Use model: for pre-existing tables and prevent measure names that match a column name #5884

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Metrics view generation: Use model: for pre-existing tables and prevent measure names that match a column name #5884

merged 2 commits into from
Oct 11, 2024

Conversation

begelundmuller
Copy link
Contributor

  • Changes generated metrics views to use model: instead of table: when referencing pre-existing tables (even if they are not Rill models with matching YAML files).
  • Prevents measure names from colliding with column names by appending a unique prefix:
    • For AI-generated measure names, it appends _measure if there's a collision
    • For the non-AI measure names, which are always sums, it appends _sum

@begelundmuller
Metrics view generation: Use model: for pre-existing tables and pre…
7030ba3 
…vent measure names that match a column name
@begelundmuller begelundmuller self-assigned this Oct 11, 2024
@ericpgreen2 ericpgreen2 merged commit 2244879 into main Oct 11, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the begelundmuller/metrics-view-ai-fixes branch October 11, 2024 17:44
ericpgreen2 pushed a commit that referenced this pull request Oct 11, 2024
@begelundmuller @ericpgreen2
Metrics view generation: Use model: for pre-existing tables and pre…
fbd72a9 
…vent measure names that match a column name (#5884)

* Metrics view generation: Use `model:` for pre-existing tables and prevent measure names that match a column name

* Add retries to make measure names unique
k-anshul pushed a commit that referenced this pull request Oct 15, 2024
@begelundmuller @k-anshul
Metrics view generation: Use model: for pre-existing tables and pre…
19f651c 
…vent measure names that match a column name (#5884)

* Metrics view generation: Use `model:` for pre-existing tables and prevent measure names that match a column name

* Add retries to make measure names unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

@begelundmuller begelundmuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@begelundmuller @ericpgreen2