-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified auth experience #5940
Unified auth experience #5940
Conversation
402228b
to
8cc397f
Compare
This reverts commit fa0a616.
fb265c6
to
2418991
Compare
On staging, when I enter an email address and click "Continue with email", nothing happens. |
Try again with Enter to submit password. I'll add the click event to the Continue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we only designate a sign-in option as "last used" once the user has successfully used it to log-in? See this Jam for two problems:
- The "last used" parenthetical switches before the next page is loaded
- I do not complete the Microsoft SSO flow, so I'd consider it "never used" not "last used"
Will only set last used in a success callback To do this the right way, we need to persist it with cookie. See https://github.com/rilldata/rill/blob/main/admin/server/auth/handlers.go#L165 |
I can remove the last usage implementation in this ref and revisit this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @djbarnwal, since you're closer to this code, can you please also give it a review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://jam.dev/c/647b8271-4469-4694-9f53-c0ec127c6b3d
Submitting email doesn't work for me. Tried firefox and chrome.
UXQA items:
We don't want that. We want to show this page instead:
Steps to repro:
|
This is a bug caused from the latest commit. Will fix |
I believe this is expected in staging. I was able to repro this error in the previous staging build. CleanShot.2024-11-11.at.11.15.51.mp4 |
|
Closes https://github.com/rilldata/rill-private-issues/issues/743
https://www.notion.so/rilldata/Unified-authentication-experience-113ba33c8f578058b2c0f8044b546e0a
https://www.figma.com/design/Qt6EyotCBS3V6O31jVhMQ7/RILL-Latest?node-id=18329-561685&node-type=instance&t=WTfGOxeg7fIZdXaq-0
To review locally:
npm run dev -w web-auth
To test in staging: https://ui.rilldata.io