child plan metadata, tax exemption for non US/Canada regions #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjain1
commented
Oct 22, 2024
admin/billing/orb.go
Outdated
| @@ -279,6 +279,35 @@ func (o *Orb) IsInvoicePaid(ctx context.Context, invoice *Invoice) bool { | |||
| return strings.EqualFold(invoice.Status, "paid") | |||
| } | |||
|
|
|||
| func (o *Orb) MarkCustomerTaxExempt(ctx context.Context, customerID string) error { | |||
| // note - hard coded to use Avalara tax provider as of now, Orb supports Avalara and TaxJar | |||
There was a problem hiding this comment.
do we need to make this configurable, if in future we change tax provider, not really urgent now ?
There was a problem hiding this comment.
I don't know, what do you think?
There was a problem hiding this comment.
Made it configurable in case we want to disable it (manually managing it) or change at some point in future.
Configurable through RILL_ADMIN_ORB_INTEGRATED_TAX_PROVIDER, default is still avalara if not set for convenience as Kristen mentioned that this is going to be our tax provider going forward, can be set to none to disable.
begelundmuller
approved these changes
Oct 22, 2024
begelundmuller
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/rilldata/rill-private-issues/issues/804
Also add support to Inherit plan metadata from parent plan. Orb automatically creates a child plan in case we override any pricing info, only one level nesting is done.