Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak redirect flow #5972

Merged
merged 3 commits into from
Oct 28, 2024
Merged

tweak redirect flow #5972

merged 3 commits into from
Oct 28, 2024

Conversation

briangregoryholmes
Copy link
Contributor

To address some concerns related to example project unpacking in certain situations, this PR makes the following changes:

  • Reduce watch-request-client priority disconnect (which applies when the tab is put in the background) to 20 seconds
  • Prevent multiple clicks on the same example project
  • If ?redirect=true is still in the URL after 5 seconds, reload the page

@briangregoryholmes briangregoryholmes self-assigned this Oct 24, 2024
ericpgreen2
ericpgreen2 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tweaks look reasonable. I'll approve and merge, and we can wait-and-see to see if anyone still reports problems.

@ericpgreen2 ericpgreen2 merged commit 4a7b1fa into main Oct 28, 2024
7 checks passed
@ericpgreen2 ericpgreen2 deleted the bgh/redirect-flow branch October 28, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

@briangregoryholmes briangregoryholmes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briangregoryholmes @ericpgreen2