Prevent dimension names that match column names on ClickHouse if the dimension has a complex expression #6063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dimension has a complex expression
k-anshul
approved these changes
Nov 8, 2024
k-anshul
deleted the
begelundmuller/validate-clickhouse-dimension-expression-name-collision
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation that prevents a ClickHouse-backed metrics view from having dimension names that collide with an underlying column name when and only when the dimension has a custom
expression:orunnest: true. This is necessary because ClickHouse eagerly substitutes aliases, and without this validation, it leads to broken references to the underlying column in other dimensions/measures and where clauses.This PR essentially implements the same constraint for dimensions as this PR added for measures: #5618. See it for details.