Canvas: Rewrite table state manangement #6499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
requested changes
Jan 24, 2025
| @@ -66,6 +70,13 @@ export class CanvasResolvedSpec { | |||
| Object.keys($validSpecStore?.data?.metricsViews || {}), | |||
| ); | |||
|
|
|||
| this.getMetricsViewFromName = (metricViewName: string) => | |||
There was a problem hiding this comment.
Nit: I'd rename to getMetricsViewValidSpecFromName, since it returns a validSpec, not the whole metricsView resource
Comment on lines
71
to
+89
| export function getTableConfig( | ||
| instanceId: string, | ||
| tableProperties: TableProperties, | ||
| ctx: StateManagers, | ||
| tableSpec: TableSpec, | ||
| pivotState: PivotState, | ||
| ): Readable<PivotDataStoreConfig> { | ||
| const { metrics_view, time_range, comparison_range } = tableProperties; | ||
| const { metrics_view, time_range, comparison_range, dimension_filters } = | ||
| tableSpec; | ||
| const { | ||
| canvasEntity: { | ||
| createTimeAndFilterStore, | ||
| spec: { getMetricsViewFromName }, | ||
| }, | ||
| } = ctx; | ||
|
|
||
| const timeAndFilterStore = createTimeAndFilterStore(metrics_view, { | ||
| componentTimeRange: time_range, | ||
| componentComparisonRange: comparison_range, | ||
| componentFilter: dimension_filters, | ||
| }); |
There was a problem hiding this comment.
Same comments as here, namely we should not instantiate a new Canvas-level timeAndFilterStore for every Component.
| tableProperties: TableProperties, | ||
| ) { | ||
| export function validateTableSchema( | ||
| ctx: StateManagers, |
There was a problem hiding this comment.
Ideally this weren't coupled to a Canvas ctx and rather accepted a metricsView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #6493
metrics_viewis changed.