feat: Dump resources command for debuggability #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
requested changes
Feb 11, 2025
begelundmuller
changed the title
begelundmuller
requested changes
Feb 12, 2025
cli/pkg/printer/resources.go
Outdated
Comment on lines
574
to
578
| switch r.Meta.Name.Kind { | ||
| case runtime.ResourceKindSource: | ||
| spec, specErr = protojson.MarshalOptions{Indent: " "}.Marshal(r.GetSource().Spec) | ||
| state, stateErr = protojson.MarshalOptions{Indent: " "}.Marshal(r.GetSource().State) | ||
| case runtime.ResourceKindModel: |
There was a problem hiding this comment.
All these cases seem excessive for an internal dump tool. Did you consider just doing a JSON roundtrip to avoid handling each type specifically? E.g. (pseudocode):
rowJSON := protojson.Marshal(r)
row := json.Unmarshal(rowJSON)
for k, v := range row {
if k != "meta" {
row["spec"] = row[k]["spec"]
row["state"] = row[k]["state"]
delete(row, k)
break
}
}
row["org"] = org
row["project"] = project
row["resource_type"] = runtime.PrettifyResourceKind(r.Meta.Name.Kind)
row["resource_name"] = r.Meta.Name.Name
return rowThere was a problem hiding this comment.
No I did not consider handling via JSON but sounds like a better idea. Modified the code.
begelundmuller
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask for https://github.com/rilldata/rill-private-issues/issues/854
Checklist: