Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace call to rime_get_api #597

Merged
merged 1 commit into from
Jan 16, 2023
Merged

replace call to rime_get_api #597

merged 1 commit into from
Jan 16, 2023

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Feature

Describe feature of pull request

Upstream a patch I use at https://github.com/LibreService/my_rime

  • It can reduce some overhead.
  • Moreover, rime_get_api stores many function pointers. If I don't use rime_get_api at all, the compiler may optimize out many unused functions to reduce binary library size.

Unit test

  • Done

Manual test

  • Done at my site

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@lotem lotem merged commit d547b69 into rime:master Jan 16, 2023
@eagleoflqj eagleoflqj deleted the replace-rime_get_api branch January 16, 2023 16:11
@eagleoflqj eagleoflqj mentioned this pull request Jun 23, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eagleoflqj @lotem