Tweak to Save Memory Consumption When Compiling Dictionaries #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use smart pointer - Release memory in time This may save about 12% memory usage when compiling dict.
This may reduce about 1% peak memory usage when compiling dict.
.cache is usually used by clangd
This may save about 18% peak memory consumption when compiling dict.
lotem
approved these changes
Jun 11, 2023
| @@ -30,20 +30,36 @@ class Code : public vector<SyllableId> { | |||
| string ToString() const; | |||
| }; | |||
|
|
|||
| struct ShortDictEntry { | |||
There was a problem hiding this comment.
How much more memory efficient is this?
If the diff by this single change is insignificant, I'd prefer not to repeat the code.
There was a problem hiding this comment.
The screenshots I pasted in the Additional Info have showed the info you get interested. In my test case, it may save about 15 % ~ 18 % of the memory consumption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #583
Feature
Describe feature of pull request
Use several techniques to try to save the memory consumption when compiling dictionaries.
This may save about 30% memory consumption.
Unit test
Manual test
Code Review
Additional Info
Tested schema: rime-ice
Before
After