Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use Ninja Build in CI #718

Merged
merged 10 commits into from
Sep 23, 2023
Merged

ci: Use Ninja Build in CI #718

merged 10 commits into from
Sep 23, 2023

Conversation

wxyzh
Copy link
Contributor

@wxyzh wxyzh commented Sep 20, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request
Use Ninja build to speed up the build in CI.
Ref: #667

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

eagleoflqj
eagleoflqj requested changes Sep 20, 2023
View reviewed changes
.github/workflows/macos-build.yml Outdated Show resolved Hide resolved
.github/workflows/macos-build.yml Show resolved Hide resolved
.github/workflows/windows-build.yml Outdated Show resolved Hide resolved
action-install-linux.sh Outdated Show resolved Hide resolved
build.bat Show resolved Hide resolved
eagleoflqj
eagleoflqj reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Ninja is used in all jobs.

Makefile Outdated Show resolved Hide resolved
build.bat Outdated Show resolved Hide resolved
.github/workflows/linux-build.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
eagleoflqj
eagleoflqj approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@eagleoflqj eagleoflqj merged commit 5106353 into rime:master Sep 23, 2023
8 checks passed
@eagleoflqj eagleoflqj mentioned this pull request Sep 23, 2023
Closed
2 tasks
@wxyzh wxyzh deleted the pr/ninja-build branch September 23, 2023 06:51
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@wxyzh @WhiredPlanck
@eagleoflqj @groverlynn
ci: Use Ninja Build in CI (rime#718)
c48b682 
* add ninja-build on Linux & add support for non-Visual-Studio makefile

* use CI create env.bat for ninja-bulid

* use ilammy/msvc-dev-cmd  configure msvc

* merge the setup in xcode.mk into Makefile

* feat(Makefile,deps.mk): add flag to control parallel build

---------

Co-authored-by: WhiredPlanck <whiredplanck@outlook.com>
Co-authored-by: wxyzh <wxyzhen@live.com>
Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@wxyzh @WhiredPlanck
@eagleoflqj @graphemecluster
ci: Use Ninja Build in CI (rime#718)
69e2384 
* add ninja-build on Linux & add support for non-Visual-Studio makefile

* use CI create env.bat for ninja-bulid

* use ilammy/msvc-dev-cmd  configure msvc

* merge the setup in xcode.mk into Makefile

* feat(Makefile,deps.mk): add flag to control parallel build

---------

Co-authored-by: WhiredPlanck <whiredplanck@outlook.com>
Co-authored-by: wxyzh <wxyzhen@live.com>
Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@wxyzh @WhiredPlanck
@eagleoflqj @graphemecluster
ci: Use Ninja Build in CI (rime#718)
de8522a 
* add ninja-build on Linux & add support for non-Visual-Studio makefile

* use CI create env.bat for ninja-bulid

* use ilammy/msvc-dev-cmd  configure msvc

* merge the setup in xcode.mk into Makefile

* feat(Makefile,deps.mk): add flag to control parallel build

---------

Co-authored-by: WhiredPlanck <whiredplanck@outlook.com>
Co-authored-by: wxyzh <wxyzhen@live.com>
Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@wxyzh @WhiredPlanck
@eagleoflqj @graphemecluster
ci: Use Ninja Build in CI (rime#718)
16bc68d 
* add ninja-build on Linux & add support for non-Visual-Studio makefile

* use CI create env.bat for ninja-bulid

* use ilammy/msvc-dev-cmd  configure msvc

* merge the setup in xcode.mk into Makefile

* feat(Makefile,deps.mk): add flag to control parallel build

---------

Co-authored-by: WhiredPlanck <whiredplanck@outlook.com>
Co-authored-by: wxyzh <wxyzhen@live.com>
Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@wxyzh @WhiredPlanck
@eagleoflqj @graphemecluster
ci: Use Ninja Build in CI (rime#718)
3303eac 
* add ninja-build on Linux & add support for non-Visual-Studio makefile

* use CI create env.bat for ninja-bulid

* use ilammy/msvc-dev-cmd  configure msvc

* merge the setup in xcode.mk into Makefile

* feat(Makefile,deps.mk): add flag to control parallel build

---------

Co-authored-by: WhiredPlanck <whiredplanck@outlook.com>
Co-authored-by: wxyzh <wxyzhen@live.com>
Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagleoflqj eagleoflqj eagleoflqj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxyzh @eagleoflqj @WhiredPlanck