Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fcitx5 Ctrl+Shift switches to rime and toggles ascii mode #936

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #935

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • In fcitx5, set 切换启用/禁用输入法 to Ctrl+Shift_L, remove Shift_L from 临时在当前和第一个输入法之间切换
  • Use a schema that uses Shift_L to toggle ascii mode
  • Increase the 500ms limit to 5000ms
  • Use Ctrl+Shift_L to switch from rime to keyboard-us
  • Press Ctrl, press Shift_L, release Ctrl, release Shift_L within 5s
  • master behavior: switch from keyboard-us to rime ascii mode, pr behavior: switch from keyboard-us to rime normal mode

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link

@moetayuko moetayuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the patch and confirmed that it fixed my problem.

@ksqsf ksqsf merged commit 9fa2bbc into master Sep 17, 2024
10 checks passed
@ksqsf ksqsf deleted the shift branch September 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ascii_composer 易通过 ctrl+shift 误触发
3 participants