Do not update packages if no_update is set. #16
Conversation
pmeiyu
changed the title
|
This change is incorrect. What is the problem you are trying to solve with this change? |
| else | ||
| echo $(info 'Found package:') $(highlight "${package}") | ||
| fi | ||
| "${script_dir}"/update-package.sh "${package_dir}" "${branch}" |
There was a problem hiding this comment.
no_update is also read in this script.
| @@ -57,10 +57,10 @@ fetch_or_update_package() { | |||
| else | |||
| if [[ -z "${option_no_update}" ]]; then | |||
| echo $(info 'Updating package:') $(highlight "${package}") | |||
| "${script_dir}"/update-package.sh "${package_dir}" "${branch}" | |||
There was a problem hiding this comment.
skipping this call could leave the working copy on a different branch.
|
I'm building rime-data on Guix. Guix does not allow updating source code when building packages. So plum should not try to update schema packages when no_update is set. When building rime-data on Guix, every schema package is downloaded by Guix and it's limited to a specific commit. If a branch is needed, then that branch's commit is downloaded. Both updating git repository and switching git branch are against the principle of reproducible builds. |
|
I understand your requirement. |
|
Currently plum throw a lot of warnings because it cannot find the git command. Guix building environment is limited to only necessary dependencies, so git is not available. Could this be fixed? |
|
Does the build system support "dev/build dependencies"? |
|
Yes I can pass git as a build time dependency, but plum still throw warnings because schema packages are not git repositories. |
|
I am porting Rime to Guix. If you are interested, please have a look at the package definition I wrote for rime-data: |
|
Wocow, it's written in lisp. |
Yeah, I know. I reported the reproducibility issue to librime, but still have no answer.
My solution is to manually specify commit id for every schema package and copy them into "package/rime" directory. I have already successfully built rime on Guix. I made this pull request to suppress build process warnings when building rime-data. It would be great if you can provide an option to prevent plum from trying to download packages and check out branches. The same option will also be useful to NixOS, a similar OS to Guix. |
Do not update packages if no_update is set.