Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RingDao site new design #23

Merged
merged 16 commits into from
Nov 28, 2024
Merged

RingDao site new design #23

merged 16 commits into from
Nov 28, 2024

Conversation

hamidroohi92
Copy link
Collaborator

This PR will close the issue #22

@boundless-forest boundless-forest marked this pull request as ready for review November 22, 2024 01:14
@DreUncle
Copy link

image
The social media icon at the bottom is not displayed, but can be clicked and jumped

@DreUncle
Copy link

image Please add mouse hover effect to each button

@DreUncle
Copy link

image In a narrow window width, the line here may have a little problem and not connect

@hamidroohi92
Copy link
Collaborator Author

Oh. Ok. Will cover them soon

@hamidroohi92
Copy link
Collaborator Author

The styling issues are fixed. Please give me also the tablet size in Figma so I can fix the issues for tablet size

@DreUncle
Copy link

The styling issues are fixed. Please give me also the tablet size in Figma so I can fix the issues for tablet size

There is no other problem with tablet size, it's just that the vertical line is not connected to the horizontal line above and below, just fix that

@hamidroohi92
Copy link
Collaborator Author

I fixed it, but I see some other issues in tablet size like iPad air or iPad mini. I am trying to fix it but if you have a any more consideration please tell me

@hamidroohi92
Copy link
Collaborator Author

Tablet size is fixed also. Please check and if ok, merge it

@boundless-forest
Copy link
Contributor

image
This link should be updated to the snapshot platform as Submit Proposals

image
Missing icoins like github, tg, medium, check out the figma design.

@hamidroohi92
Copy link
Collaborator Author

Which size are you checking at?

@boundless-forest
Copy link
Contributor

Which size are you checking at?

https://ringdao-home-ayjq13irs-itering.vercel.app/ The latest one generated by vercel.

@hamidroohi92
Copy link
Collaborator Author

It is a bit strange I have all the logos and icons in my local version. Let me check it again

@hamidroohi92
Copy link
Collaborator Author

@boundless-forest Ready for review

@boundless-forest boundless-forest merged commit 8713f59 into main Nov 28, 2024
1 check passed
@boundless-forest boundless-forest deleted the hidotmatrix/feat/redesign branch November 28, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants