Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAPI Audit#1 #5

Merged
merged 2 commits into from
Oct 10, 2024
Merged

XAPI Audit#1 #5

merged 2 commits into from
Oct 10, 2024

Conversation

jiguantong
Copy link
Collaborator

@jiguantong jiguantong commented Oct 10, 2024

https://github.com/itering/internal-security-audit/pull/137#issuecomment-2403856456

XAPI

  • Rename fulfillAddress to exAggregator
  • Use exAggregator as aggregatorConfigs' key
  • Allow anyone to set aggregatorConfig
  • Use exAggregator to make request
  • Replace perReporterFee * quorum with reportersFee

Aggregator

  • Organize nonce and fee options in MpcOptions
  • More fields for chainConfig
  • Emit SetPublishChainConfigEvent
  • Aggregator can sync publish config to remote chain through mpc

@jiguantong jiguantong self-assigned this Oct 10, 2024
@jiguantong jiguantong marked this pull request as ready for review October 10, 2024 07:31
@jiguantong jiguantong merged commit bb1a334 into main Oct 10, 2024
@jiguantong jiguantong deleted the guantong/audit1 branch October 10, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant