Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust diagnostic messages to be correct when applied with MapValue #1332

Merged
merged 1 commit into from
Jun 12, 2024
Merged

adjust diagnostic messages to be correct when applied with MapValue #1332

merged 1 commit into from
Jun 12, 2024

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jun 12, 2024

Rel #631
Removes mentioning "member" and "MapPropertyAttribute" from diagnostic messages as this would be constant values and "MapValueAttribute" with #631

@latonz latonz self-assigned this Jun 12, 2024
@latonz latonz requested a review from ni507 June 12, 2024 04:18
@latonz latonz marked this pull request as ready for review June 12, 2024 04:20
@latonz latonz enabled auto-merge (squash) June 12, 2024 04:20
@latonz latonz changed the title fix: adjust diagnostic messages to be gramatically correct when applied with MapValue fix: adjust diagnostic messages to be correct when applied with MapValue Jun 12, 2024
@latonz latonz merged commit 84ae17f into riok:main Jun 12, 2024
17 checks passed
@latonz latonz deleted the fix/diagnostic-messages branch June 12, 2024 06:28
@latonz latonz added the bug Something isn't working label Jun 30, 2024
@latonz latonz changed the title fix: adjust diagnostic messages to be correct when applied with MapValue adjust diagnostic messages to be correct when applied with MapValue Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants