Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inline expression with casting #1419

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Support inline expression with casting #1419

merged 3 commits into from
Aug 5, 2024

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Jul 26, 2024

Support inline expression with casting

Description

When using Use = nameof(), which contains casting, e.g. ((MyEnum) value & MyEnum.OptionA) > 0 generated mapping does not resolve the fully qualified type of the casted type.

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@trejjam trejjam force-pushed the feature/inline-expression-with-casting branch 5 times, most recently from e259090 to 291fc6b Compare July 31, 2024 13:48
latonz
latonz requested changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution, I added my feedback 😊

src/Riok.Mapperly/Descriptors/InlineExpressionRewriter.cs Outdated Show resolved Hide resolved
test/Riok.Mapperly.Tests/Helpers/InlineExpressionRewriterTest.cs Outdated Show resolved Hide resolved
@latonz latonz added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Aug 3, 2024
@trejjam trejjam force-pushed the feature/inline-expression-with-casting branch from 291fc6b to 3af5f54 Compare August 3, 2024 09:55
@trejjam trejjam requested a review from latonz August 3, 2024 10:01
@trejjam trejjam force-pushed the feature/inline-expression-with-casting branch from 3af5f54 to b64f8be Compare August 4, 2024 12:35
@latonz latonz force-pushed the feature/inline-expression-with-casting branch from b64f8be to 6e43ca4 Compare August 5, 2024 17:02
@latonz latonz enabled auto-merge (squash) August 5, 2024 17:03
@latonz
Copy link
Contributor

latonz commented Aug 5, 2024

Thank you for this contribution!

@latonz latonz merged commit 276f6f4 into riok:main Aug 5, 2024
17 checks passed
@trejjam trejjam deleted the feature/inline-expression-with-casting branch August 5, 2024 18:39
@trejjam
Copy link
Contributor Author

trejjam commented Aug 5, 2024

Thank you for processing it. Is it possible to publish a new release? A pre-release is fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latonz latonz latonz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trejjam @latonz