Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inlining of method with generic type arguments #1498

Merged

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Sep 19, 2024

Support inlining of method with generic type arguments

Description

Inlining of

public class Test
{
    public IReadOnlyCollection<A> MapExpression(A value) => Array.Empty<A>();
}

Produces:
global::System.Array.Empty()

instead of
global::System.Array.Empty<global::A>()

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@trejjam trejjam force-pushed the feature/inline-method-with-generic-argument branch from 97f3fd3 to 002b51d Compare September 19, 2024 14:19
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this bug fix!

@latonz latonz added the bug Something isn't working label Sep 19, 2024
@latonz latonz merged commit c65d873 into riok:main Sep 19, 2024
17 of 18 checks passed
@trejjam trejjam deleted the feature/inline-method-with-generic-argument branch September 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants