Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to specify the format provider / culture of a property #929

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: Add option to specify the format provider / culture of a property #929

merged 1 commit into from
Nov 22, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Nov 20, 2023

Add option to specify the format provider / culture of a property

Description

Adds an option to specify format providers and cultures to use when converting an IFormattable.

Depends on #921
Fixes #887

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8ee92f4) 91.20% compared to head (c90a97f) 91.27%.

Files Patch % Lines
...scriptors/FormatProviders/FormatProviderBuilder.cs 92.30% 1 Missing and 1 partial ⚠️
...Riok.Mapperly.Abstractions/MapPropertyAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
+ Coverage   91.20%   91.27%   +0.06%     
==========================================
  Files         217      221       +4     
  Lines        6996     7074      +78     
  Branches      878      886       +8     
==========================================
+ Hits         6381     6457      +76     
- Misses        408      410       +2     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@latonz latonz marked this pull request as ready for review November 21, 2023 15:15
@latonz latonz enabled auto-merge (squash) November 22, 2023 10:43
@latonz latonz merged commit 42d3e26 into riok:main Nov 22, 2023
19 checks passed
@latonz latonz deleted the 887-property-format-provider branch November 22, 2023 10:46
Copy link

🎉 This PR is included in version 3.3.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify Format and Culture when converting to strings
2 participants