updated: use the template key instead of fallback for the slot bindings

riot · Aug 23, 2024 · 68a5a07 · 68a5a07
1 parent 458a7b0
commit 68a5a07
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/dom-bindings.d.ts b/dom-bindings.d.ts
@@ -89,7 +89,7 @@ export interface SimpleBindingData<Scope = any> extends BaseBindingData<Scope> {
 }
 
 export interface SlotBindingData<Scope = any> extends BaseBindingData<Scope> {
-  fallback?: TemplateChunk<Scope>
+  template?: TemplateChunk<Scope>
 }
 
 export interface TagBindingData<Scope = any> extends BaseBindingData<Scope> {

diff --git a/src/bindings/slot.js b/src/bindings/slot.js
@@ -28,7 +28,6 @@ export const SlotBinding = {
   // name: null,
   attributes: [],
   // template: null,
-  // fallback: null
 
   getTemplateScope(scope, parentScope) {
     return extendParentScope(this.attributes, scope, parentScope)
@@ -42,13 +41,14 @@ export const SlotBinding = {
     const { parentNode } = this.node
     const realParent = getRealParent(scope, parentScope)
 
+    // override the template property if the slot needs to be replaced
     this.template =
       (templateData &&
         template(templateData.html, templateData.bindings).createDOM(
           parentNode,
         )) ||
-      // use the optional template fallback if provided by the compiler see also https://github.com/riot/riot/issues/3014
-      this.fallback
+      // otherwise use the optional template fallback if provided by the compiler see also https://github.com/riot/riot/issues/3014
+      this.template
 
     if (this.template) {
       cleanNode(this.node)
@@ -107,11 +107,11 @@ function moveSlotInnerContent(slot) {
  * @param   {AttributeExpressionData[]} attributes - slot attributes
  * @returns {Object} Slot binding object
  */
-export default function createSlot(node, { name, attributes, fallback }) {
+export default function createSlot(node, { name, attributes, template }) {
   return {
     ...SlotBinding,
     attributes,
-    fallback,
+    template,
     node,
     name,
   }

diff --git a/test/bindings/slot.spec.js b/test/bindings/slot.spec.js
@@ -444,7 +444,7 @@ describe('slot bindings', () => {
         type: bindingTypes.SLOT,
         selector: '[expr0]',
         name: 'default',
-        fallback: template('<p>Default</p>'),
+        template: template('<p>Default</p>'),
       },
     ])