feat: add amendments list page #836
Conversation
pdp2121
changed the title
|
What's the difference between "voters" and "consensus"? |
Voters is the number of UNL voters who voted 'Yea', while consensus is voters/number of UNL validators. You can tell the consensus by voters and vice versa, I just follow the design here |
|
Can we move the |
@bugsbunnies I have updated the distance between |
|
Not really a fan of the navigation change. I think the "Network" navigation item should not be collapsed with "Explorer". Instead i would like to see:
|
|
|
||
| it('renders all parts', () => { | ||
| const wrapper = createWrapper({ amendments }) | ||
| expect(wrapper.find('tr').length).toBe(amendments.length + 1) |
There was a problem hiding this comment.
I would like to see some more detailed tests that check specific column's data.
There was a problem hiding this comment.
The detailed test for each column (for both enabled and voting amendments) is in the amendments.test.js file. I'm just following the same structure as the tests in the Network folder here.
@ckniffen the navigation has been updated as in the screenshot. |
pdp2121
changed the title
| } | ||
| } | ||
|
|
||
| .wrap { |
There was a problem hiding this comment.
Try using <section> tags instead. I think there is styling for that already that falls within these sizes.
There was a problem hiding this comment.
I think the only place where the same style is being used in .network-page .wrap and I don't see any <section> tag being used anywhere else in the code
High Level Overview of Change
The Explorer will roll out new features to include voting data (amendments + fee) soon. This page will be one of the new feature added.
Add a amendments page to display all amendments in voting and enabled.
Note that the links to specific amendment summary page (name, id) is not yet enabled (still white text). It will be updated once the amendment summary page has been created.
Please do not merge this PR until the validator-history-service has been updated with voting data.
Type of Change
Before / After
Desktop View
Mobile View
Add Amendment Summary page for each individual amendment