Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show info for old transactions #843

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

ckniffen
Copy link
Collaborator

@ckniffen ckniffen commented Sep 28, 2023

High Level Overview of Change

Viewing old transactions was broken by #835. When sending api_version: 1 to clio it will currently forward to a rippled node which is not full history. That will be addresses soon but until then wont send now that for every request.

Explicitly send api_version when getting account_info because we only want the result from the most recently validated ledger.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Viewing old transactions was broken by #835. When sending
`api_version: 1` to clio it will currently forward to a rippled node
which is not full history. That will be addresses soon but until then
wont send now that for every request.

Explicitly send api_version to get `account_info` because we only want
the result from the most recently validated ledger.
Copy link
Collaborator

@pdp2121 pdp2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit 00ee746 into staging Sep 28, 2023
4 checks passed
@ckniffen ckniffen deleted the bugfix/support-old-tx branch September 28, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants