-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap for 1.0-rc.7 changes #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wollac
approved these changes
Jun 3, 2024
nategraf
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding those tests. Definitely a good thing to check.
nategraf
added a commit
that referenced
this pull request
Jun 3, 2024
- Run bootstrap from risc0 - Manually fix testSelectorIsStable constant (should be made part of the previous bootstrap in the future) - Add tests to check stability of `CONTROL_ROOT` and `BN254_CONTROL_ID` , so that we directly exercise those values rather than only in the `erc20-counter` example, where its failure is cryptic. --------- Co-authored-by: Victor Graf <victor@risczero.com>
nategraf
added a commit
that referenced
this pull request
Jun 4, 2024
…0-rc.7 (#136) Includes the following three PRs: - bootstrap for 1.0-rc.7 changes (#133) - Add bonsai integration CI workflow (#135) - update risc0 dependencies to 1.0.0-rc.7 (#132) --------- Co-authored-by: Angelo Capossele <angelocapossele@gmail.com> Co-authored-by: Erik Kaneda <erik@risczero.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTROL_ROOT
andBN254_CONTROL_ID
, so that we directly exercise those values rather than only in theerc20-counter
example, where its failure is cryptic.