Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap for 1.0-rc.7 changes #133

Merged
merged 4 commits into from
Jun 3, 2024
Merged

bootstrap for 1.0-rc.7 changes #133

merged 4 commits into from
Jun 3, 2024

Conversation

capossele
Copy link
Contributor

@capossele capossele commented Jun 3, 2024

  • Run bootstrap from risc0
  • Manually fix testSelectorIsStable constant (should be made part of the previous bootstrap in the future)
  • Add tests to check stability of CONTROL_ROOT and BN254_CONTROL_ID , so that we directly exercise those values rather than only in the erc20-counter example, where its failure is cryptic.

@capossele capossele changed the title bootstrap bootstrap for rc.7 changes Jun 3, 2024
@capossele capossele changed the title bootstrap for rc.7 changes bootstrap for 1.0-rc.7 changes Jun 3, 2024
@capossele capossele self-assigned this Jun 3, 2024
@capossele capossele requested review from nategraf and Wollac June 3, 2024 11:47
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding those tests. Definitely a good thing to check.

contracts/src/groth16.rs Outdated Show resolved Hide resolved
contracts/src/groth16.rs Outdated Show resolved Hide resolved
@nategraf nategraf enabled auto-merge (squash) June 3, 2024 16:15
@nategraf nategraf merged commit 0710cd5 into main Jun 3, 2024
9 checks passed
@nategraf nategraf deleted the capossele/bootstrap-rc.7 branch June 3, 2024 16:25
nategraf added a commit that referenced this pull request Jun 3, 2024
- Run bootstrap from risc0
- Manually fix testSelectorIsStable constant (should be made part of the
previous bootstrap in the future)
- Add tests to check stability of `CONTROL_ROOT` and `BN254_CONTROL_ID`
, so that we directly exercise those values rather than only in the
`erc20-counter` example, where its failure is cryptic.

---------

Co-authored-by: Victor Graf <victor@risczero.com>
nategraf added a commit that referenced this pull request Jun 4, 2024
…0-rc.7 (#136)

Includes the following three PRs:
- bootstrap for 1.0-rc.7 changes (#133)
- Add bonsai integration CI workflow (#135)
- update risc0 dependencies to 1.0.0-rc.7 (#132)

---------

Co-authored-by: Angelo Capossele <angelocapossele@gmail.com>
Co-authored-by: Erik Kaneda <erik@risczero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants