Refactor contract README.md #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdg744
reviewed
Jun 12, 2024
| [groth16-article]: https://www.risczero.com/news/on-chain-verification | ||
| [IRiscZeroVerifier]: ./src/IRiscZeroVerifier.sol |
There was a problem hiding this comment.
question: mb this should point to a tagged release?
There was a problem hiding this comment.
It points locally because they are viewing this on a given git ref. If they are on main, they'll expect this link to take them to the implementation on main, and if you are interested in the released version they should open this README on that branch instead.
There was a problem hiding this comment.
When/if we link to this file from the docs, we should link toa tagged release.
pdg744
approved these changes
Jun 12, 2024
|
tagging @sashaaldrick and @nuke-web3 for visibility |
nategraf
added a commit
that referenced
this pull request
Jun 13, 2024
nategraf
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #108