Improve groth16 encode API #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
reviewed
Jul 18, 2024
contracts/src/groth16.rs
Outdated
| /// Encoding of a [Groth16Receipt][risc0_zkvm::Groth16Receipt] by prefixing it with the verifier selector, | ||
| /// taken from the first 4 bytes of the hash of the verifier parameters including the Groth16 | ||
| /// verification key and the control IDs that commit to the RISC Zero circuits. | ||
| pub fn encode(receipt: &Groth16Receipt<ReceiptClaim>) -> Vec<u8> { |
There was a problem hiding this comment.
How will we recommend going from https://docs.rs/bonsai-sdk/0.9.0/bonsai_sdk/responses/struct.SnarkReceipt.html, given we still recommend using bonsai-sdk over the zkvm for production use cases?
nategraf
requested changes
Jul 22, 2024
…o capossele/improve-groth16
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending #185
Attempt at solving #174 and #176.
Closes #174
Closes #176