WEB3-66: Add version string to RiscZeroGroth16Verifier.sol #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
capossele
approved these changes
Aug 7, 2024
capossele
reviewed
Aug 7, 2024
| @@ -53,6 +53,9 @@ contract RiscZeroGroth16Verifier is IRiscZeroVerifier, Groth16Verifier { | |||
| using OutputLib for Output; | |||
| using SafeCast for uint256; | |||
|
|
|||
| /// Semantic version of the the RISC Zero system of which this contract is part. | |||
| string constant VERSION = "1.1.0-alpha.1"; | |||
There was a problem hiding this comment.
I wonder though, let's say no changes in the verifier contract between x.x.0 and x.x.5 are required, does that mean the deployed contract will keep an older version than the latest crate version?
There was a problem hiding this comment.
That's a good question. I think both changing it or not changing it is fine but I'm not sure which is better. Mostly it's there to make it easier to find the source code in GitHub when you are looking at the contract source in Etherscan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make it easier to determine which version a given verifier contract is, this PR adds a semantic version string.
Note that this does mean an additional step in the release process. I couldn't think of a way to make this automatic.