WEB3-113: chore: CI coverage of examples #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
nategraf
approved these changes
Sep 10, 2024
| RISC0_SKIP_BUILD: true | ||
| - run: sccache --show-stats | ||
|
|
||
| test-risc0-ethereum: |
There was a problem hiding this comment.
Why suffix test with risc0-ethereum, given that we are in the risc0-ethereum repo?
There was a problem hiding this comment.
Because it only runs cargo test on the main workspace and not examples etc. There is a separate job for that.
Wollac
added a commit
that referenced
this pull request
Oct 7, 2024
Inspired by #227 this PR runs `cargo fmt` `cargo sort` `cargo clippy` `cargo test` and `forge tests` for all examples in the CI. It uses a bash script to find all examples under the `example` folder instead of manually listing them. It also addresses all the found linter warnings. closes WEB3-109 closes Web3-110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #227 this PR runs
cargo fmtcargo sortcargo clippycargo testandforge testsfor all examples in the CI.It uses a bash script to find all examples under the
examplefolder instead of manually listing them.It also addresses all the found linter warnings.
closes WEB3-109
closes Web3-110