Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEB3-107: fix: Specific error when Contract::preflight was missed. #239

Merged
merged 7 commits into from
Sep 12, 2024
Merged

WEB3-107: fix: Specific error when Contract::preflight was missed. #239

merged 7 commits into from
Sep 12, 2024

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Sep 11, 2024

Returns "no accounts accessed: use Contract::preflight" when no Contract::preflight was called.

closes #224
closes WEB3-107

@linear Linear
Copy link

linear bot commented Sep 11, 2024

WEB3-107 Forgetting to run `Contract::preflight` results in difficult to debug error

@Wollac Wollac self-assigned this Sep 11, 2024
@github-actions github-actions bot changed the title fix: Specific error when Contract::preflight was missed. WEB3-107: fix: Specific error when Contract::preflight was missed. Sep 11, 2024
nategraf
nategraf approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this will be helpful

@Wollac Wollac enabled auto-merge (squash) September 12, 2024 21:01
@Wollac Wollac merged commit 82be079 into main Sep 12, 2024
11 checks passed
@Wollac Wollac deleted the fix/no-preflight branch September 12, 2024 22:08
Wollac added a commit that referenced this pull request Oct 7, 2024
@Wollac
WEB3-107: fix: Specific error when Contract::preflight was missed. (#…
59491b6 
…239)

Returns "no accounts accessed: use Contract::preflight" when no
`Contract::preflight` was called.

closes #224 
closes WEB3-107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nategraf nategraf nategraf approved these changes

@capossele capossele Awaiting requested review from capossele capossele is a code owner

Assignees

@Wollac Wollac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forgetting to run Contract::preflight results in difficult to debug error
2 participants
@Wollac @nategraf