-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB3-164: added new Steel readme + relevant docs #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
draft: added new Steel readme + relevant docs
WEB3-164: draft: added new Steel readme + relevant docs
Oct 3, 2024
…ppets to correct language for formatting
sashaaldrick
changed the title
WEB3-164: draft: added new Steel readme + relevant docs
WEB3-164: added new Steel readme + relevant docs
Oct 4, 2024
Wollac
reviewed
Oct 4, 2024
steel/docs/steel-commitments.md
Outdated
|
||
The second method allows validation using the [EIP-4788] beacon roots contract. This technique extends the time window in which the proof can be validated on-chain to just over a day, making it suitable for scenarios requiring more extensive computation. It requires access to a beacon API endpoint and can be enabled by calling `EvmEnv::into_beacon_input`. However, this approach is specific to Ethereum Steel proofs and depends on the implementation of EIP-4788. | ||
|
||
Note that EIP-4788 only provides access to the parent beacon root, requiring iterative queries in Solidity to retrieve the target beacon root for validation. This iterative process can result in slightly higher gas costs compared to using the `blockhash` opcode. Overall, it is suitable for environments where longer proof generation times are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be adapted according to #265
Wollac
reviewed
Oct 7, 2024
nategraf
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of right now, forge build
with the new create-steel-app
fails
Compiler run failed:
Error (9582): Member "blockRoot" not found or not visible after argument-dependent lookup in type(library Beacon).
--> contracts/test/Counter.t.sol:76:30:
|
76 | bytes32 beaconRoot = Beacon.blockRoot(beaconTimestamp);
| ^^^^^^^^^^^^^^^^
Error:
Compilation failed
nategraf
reviewed
Oct 7, 2024
nategraf
reviewed
Oct 7, 2024
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Wollac
approved these changes
Oct 7, 2024
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Wollac
added a commit
that referenced
this pull request
Oct 7, 2024
This cleans up the README to add a new introduction, documentation for a Steel walkthrough, and getting started with Steel using `create-steel-app` for erc20-counter. --------- Co-authored-by: Victor Graf <victor@risczero.com> Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the README to add a new introduction, documentation for a Steel walkthrough, and getting started with Steel using
create-steel-app
for erc20-counter.