Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB3-162: Fix broken links #277

Merged
merged 2 commits into from
Oct 3, 2024
Merged

WEB3-162: Fix broken links #277

merged 2 commits into from
Oct 3, 2024

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Oct 3, 2024

Fixes #271
Fixes WEB3-162

@Wollac Wollac requested a review from a team as a code owner October 3, 2024 17:04
Copy link

linear bot commented Oct 3, 2024

@github-actions github-actions bot changed the title Fix broken links WEB3-162: Fix broken links Oct 3, 2024
@Wollac Wollac enabled auto-merge (squash) October 3, 2024 21:05
@Wollac Wollac requested a review from capossele October 3, 2024 21:24
Copy link
Contributor

@capossele capossele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion

@@ -1,5 +1,3 @@
# RISC Zero Forge FFI

This tool provides a Command Line Interface (CLI) enabling the communication between the [Foundry Forge ffi cheatcode](https://book.getfoundry.sh/cheatcodes/ffi) and the RISC Zero zkVM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This tool provides a Command Line Interface (CLI) enabling the communication between the [Foundry Forge ffi cheatcode](https://book.getfoundry.sh/cheatcodes/ffi) and the RISC Zero zkVM.
This tool provides a Command Line Interface (CLI) enabling the communication between the [Foundry Forge ffi cheatcode](https://book.getfoundry.sh/cheatcodes/ffi) and the RISC Zero zkVM.
The [RiscZeroCheats](../contracts/src/test/RiscZeroCheats.sol) contract shows an example of how to integrate this tool.

@Wollac Wollac merged commit ee1c455 into main Oct 3, 2024
11 checks passed
@Wollac Wollac deleted the chore/fix-links branch October 3, 2024 21:34
Wollac added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Docs is not aligning with source code correctly
2 participants