Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor and fix lints #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petarvujovic98
Copy link

Refactor some format arg captures
Refactor nested if statements into guard clauses
Refactor if-else chains into match pattern

Refactor some format arg captures
Refactor nested if statements into guard clauses
Refactor if-else chains into match pattern
Copy link
Contributor

@Wollac Wollac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes the non-format changes, but I was wondering what your motivation was for these captured format arguments?
I guess previously in the codebase we always favored the non-captured version.

If we decide to merge these particular format changes, there should be a way to check this in the CI.

@petarvujovic98
Copy link
Author

I believe that it makes the statements more readable, that's pretty much the only reason behind them. Not sure if there is a way to check for this in CI, but I might be able to have a look at it if it's a requirement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants