target/riscv: added translation drivers #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fk-sc
force-pushed
the
translation-drivers
branch
from
773f9ba
to
c6db037
Compare
|
@MarekVCodasip , @JanMatCodasip could you take a look, please? |
fk-sc
force-pushed
the
translation-drivers
branch
from
c6db037
to
56ac03b
Compare
en-sc
previously approved these changes
Oct 16, 2024
fk-sc
force-pushed
the
translation-drivers
branch
from
56ac03b
to
662ff69
Compare
|
@JanMatCodasip thank you for the review. All threads were addressed |
fk-sc
force-pushed
the
translation-drivers
branch
from
662ff69
to
eee1622
Compare
Existing flags: 'enable_virtual' and 'enable_virt2phys' were replaced with explicit translation drivers. Motivation: (1) Having 'enable_virtual' and 'enable_virt2phys' flags set simultaneously may cause double address translation which is unacceptable (2) Flags were global for all targets which is wrong too Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
fk-sc
force-pushed
the
translation-drivers
branch
from
eee1622
to
6a27d9f
Compare
JanMatCodasip
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing flags: 'enable_virtual' and 'enable_virt2phys' were replaced with explicit translation drivers. Motivation:
(1) Having 'enable_virtual' and 'enable_virt2phys' flags set simultaneously may cause double address translation which is unacceptable
(2) Flags were global for all targets which is wrong too