-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target/riscv: added translation drivers #1152
Conversation
773f9ba
to
c6db037
Compare
@MarekVCodasip , @JanMatCodasip could you take a look, please? |
c6db037
to
56ac03b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (reviewed internally).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks very good to me and makes the TCL interface for virt2phys configuration much clearer than it is now.
I have only minor comments, mostly just suggestions for renaming or reword in documentation. Please if you can check them out.
56ac03b
to
662ff69
Compare
@JanMatCodasip thank you for the review. All threads were addressed |
662ff69
to
eee1622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
Existing flags: 'enable_virtual' and 'enable_virt2phys' were replaced with explicit translation drivers. Motivation: (1) Having 'enable_virtual' and 'enable_virt2phys' flags set simultaneously may cause double address translation which is unacceptable (2) Flags were global for all targets which is wrong too Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
eee1622
to
6a27d9f
Compare
Existing flags: 'enable_virtual' and 'enable_virt2phys' were replaced with explicit translation drivers. Motivation:
(1) Having 'enable_virtual' and 'enable_virt2phys' flags set simultaneously may cause double address translation which is unacceptable
(2) Flags were global for all targets which is wrong too