Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGILL on rdcycle, which becomes a privileged instruction since linux 6.6 #2

Closed
1 of 3 tasks
kxxt opened this issue Jul 17, 2024 · 4 comments
Closed
1 of 3 tasks

Comments

@kxxt
Copy link

kxxt commented Jul 17, 2024

All rdcycle usage should be replaced/removed from the codebase.

@kxxt
Copy link
Author

kxxt commented Jul 17, 2024

For abseil-cpp, it's already fixed in main branch of chromium's vendored copy: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/abseil-cpp/absl/base/internal/unscaledcycleclock.cc by 03b48d871136a25321821618e5b2544ee8dec4b0 https://chromium-review.googlesource.com/c/chromium/src/+/5404980

It's introduced into chromium in 115290d7e28203c9275c89cc301271ba56157e48 https://chromium-review.googlesource.com/c/chromium/src/+/3161995

I still need to determine which electron versions are affected.

@kxxt
Copy link
Author

kxxt commented Jul 18, 2024

chromium [96.0.4644.0, 125.0.6395.0) is affected, which corresponds to electron [18, 30].

electron 31 is not affected.

electron 29 and 30 will be fixed.

If anyone need support for EOL electron versions(26, 27, 28), please leave a comment here.

@kxxt
Copy link
Author

kxxt commented Jul 18, 2024

./../../third_party/abseil-cpp/absl/base/internal/unscaledcycleclock.cc:128 is fixed in

  • Binary releases of v30.2.0.riscv2, v29.4.5.riscv2, v29.4.0.riscv3
  • Source branch v30.2.0-riscv, v29.4.5-riscv, v29.4.0-riscv, v28.3.3-riscv

@kxxt
Copy link
Author

kxxt commented Jul 21, 2024

Closing as the absl one is the only real world usage found.

@kxxt kxxt closed this as completed Jul 21, 2024
kxxt added a commit to kxxt/vscodium that referenced this issue Jul 21, 2024
kxxt added a commit to kxxt/archriscv-packages that referenced this issue Aug 14, 2024
Pick up some chromium/v8 patches to

- Fix v8 performance regression
  (riscv-forks/electron#1)
- Fix rdcycle SIGILL on linux >= 6.6 (riscv-forks/electron#2)

There's no riscv specific security patch needs backporting for this
release.

Use nodejs in makedepends again because it seems nodejs no longer hangs
when building this package in qemu.
kxxt added a commit to kxxt/archriscv-packages that referenced this issue Aug 14, 2024
Pick up some chromium/v8 patches to

- Fix v8 performance regression
  (riscv-forks/electron#1)
- Fix rdcycle SIGILL on linux >= 6.6 (riscv-forks/electron#2)

There's no riscv specific security patch needs backporting for this
release.

Fix rotten and use nodejs in makedepends again because it seems nodejs no longer hangs
when building this package in qemu.
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this issue Aug 14, 2024
Pick up some chromium/v8 patches to

- Fix v8 performance regression
  (riscv-forks/electron#1)
- Fix rdcycle SIGILL on linux >= 6.6 (riscv-forks/electron#2)

There's no riscv specific security patch needs backporting for this
release.

Fix rotten and use nodejs in makedepends again because it seems nodejs no longer hangs
when building this package in qemu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant