Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRS-I acting outside its own scope is a contradiction #181

Closed
jhauser-us opened this issue Jul 30, 2024 · 6 comments
Closed

BRS-I acting outside its own scope is a contradiction #181

jhauser-us opened this issue Jul 30, 2024 · 6 comments
Assignees

Comments

@jhauser-us
Copy link

In Section 2.1, "BRS-I Recipe", we have this statement: "A key tenet of BRS-I is constraining behavior outside the scope of BRS-I." To me, that reads as an impossible contradiction, saying that recipe BRS-I acts outside the realm in which it may act.

@andreiw
Copy link
Collaborator

andreiw commented Aug 6, 2024

The intention is clarified in the following sentence - "Features violating the principle of least surprise and causing anomalous and unexpected behavior in a generic OS must be configured by firmware as opt-in."

So the purpose was to state BRS-I systems as being conservative with respect to behavior that is not covered by the spec.

Please suggest a good wording.

@avpatel
Copy link
Collaborator

avpatel commented Oct 24, 2024

I believe this is already taken care hence closing.

@avpatel avpatel closed this as completed Oct 24, 2024
@jhauser-us
Copy link
Author

The consensus of the Architecture Review Committee is that this sentence reads as self-contradictory: "A key tenet of BRS-I is constraining behavior outside the scope of BRS-I." Please find different words to convey what you really mean.

@vlsunil
Copy link
Collaborator

vlsunil commented Dec 3, 2024

@jhauser-us :

"A key tenet of BRS-I is to ensure there is no unexpected behavior in a generic OS even when there are features implemented in the system beyond the scope of BRS-I."

Is it acceptable?

@avpatel avpatel reopened this Dec 3, 2024
@kasanovic
Copy link

This is still contradictory. I believe the previous paragraph provides most of the intended mandate. I'd propose dropping the problematic paragraph, and instead adding a new final sentence on the previous paragraph that states: "Any additional firmware features that cause anomalous and unexpected behavior must be disabled by default, and only enabled by opt-in."

@vlsunil
Copy link
Collaborator

vlsunil commented Dec 4, 2024

Sure. Thanks!

vlsunil added a commit to vlsunil/riscv-brs that referenced this issue Dec 5, 2024
Make changes as per the recommendation from ARC.

Fixes: riscv-non-isa#181
Suggested-by: Krste Asanovic <krste@sifive.com>
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
@avpatel avpatel closed this as completed in 86e553c Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants